Read the name and properties of the instance only in getInstance service.#10423
Closed
xzyJavaX wants to merge 3 commits intoapache:masterfrom
Closed
Read the name and properties of the instance only in getInstance service.#10423xzyJavaX wants to merge 3 commits intoapache:masterfrom
getInstance service.#10423xzyJavaX wants to merge 3 commits intoapache:masterfrom
Conversation
Member
|
If you want to add this, please make sure query dao would use this. |
wu-sheng
added
backend
wu-sheng
reviewed
Feb 24, 2023
wu-sheng
changed the title
getInstance service.
Member
|
@kezhenxu94 Please take a look. |
kezhenxu94
approved these changes
Feb 24, 2023
Member
@xzyJavaX You are better to keep consistent logic in JDBCMetadataQueryDAO` |
wu-sheng
requested changes
Feb 24, 2023
Member
wu-sheng
left a comment
wu-sheng
left a comment
There was a problem hiding this comment.
I think it is wrong to build only two columns, even for BanyanDB.
@lujiajing1126 It seems BanyanDB implementation doesn't return required fields.
Member
|
Close for now until we have a real use case to use Sources of ElasticSearch accessing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGESlog.